Skip to content

Prepend [Closed] to name when closing help channels#2581

Merged
wookie184 merged 1 commit into
mainfrom
Prepend-closed-to-closed-help-channels
May 7, 2023
Merged

Prepend [Closed] to name when closing help channels#2581
wookie184 merged 1 commit into
mainfrom
Prepend-closed-to-closed-help-channels

Conversation

@ChrisLovering
Copy link
Copy Markdown
Member

@ChrisLovering ChrisLovering commented May 5, 2023

This is to better indicate channels that have been closed when viewing them from the forum post list.

That was suggested by Ivo#4985 in #community-feedback

@ChrisLovering ChrisLovering force-pushed the Prepend-closed-to-closed-help-channels branch 2 times, most recently from 99b08c9 to c70485f Compare May 5, 2023 11:20
@mbaruh
Copy link
Copy Markdown
Member

mbaruh commented May 5, 2023

I wonder whether it's worth "ruining" the post title to add this indicator. Could also change it to "🔒" to make it shorter and make it less likely to happen (in that case it might make more sense to not add a placeholder for minimal disruption, as it would only remove one or two characters)

@wookie184
Copy link
Copy Markdown
Contributor

I think this is a good idea, but agree using 🔒 might be nicer.

@ChrisLovering ChrisLovering force-pushed the Prepend-closed-to-closed-help-channels branch 2 times, most recently from c329fde to da4a2a7 Compare May 7, 2023 15:47
@ChrisLovering
Copy link
Copy Markdown
Member Author

@mbaruh @wookie184 Updated

wookie184
wookie184 previously approved these changes May 7, 2023
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - works nicely, thanks!

This is to better indicate channels that have been closed when viewing them from the forum post list
@ChrisLovering ChrisLovering force-pushed the Prepend-closed-to-closed-help-channels branch from da4a2a7 to 9f837ac Compare May 7, 2023 16:13
@python-discord-policy-bot python-discord-policy-bot Bot dismissed wookie184’s stale review May 7, 2023 16:27

Dismissed because the approval was invalidated by another commit

@wookie184 wookie184 merged commit 1a4435c into main May 7, 2023
@wookie184 wookie184 deleted the Prepend-closed-to-closed-help-channels branch May 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants